user32: combine horizontal and vertical window scroll bar info in a single structure.

Alexandre Julliard julliard at winehq.org
Fri May 1 15:15:16 CDT 2009


Rein Klazes <wijn at online.nl> writes:

> What is already in the tests:
>
> 1) You need the alloc flag for instance when SetScrollInfo or
> SetScrollRange is called on a window without the WS_[HV]SCROLL styles. I
> can add a test that shows that the window styles remain unchanged when
> eg. SetScrollInfo creates the scrollinfo.
>
> 2) You need the style test when testing GetScrollInfo and GetScrollRange
> on windows with WS_[HV]SCROLL styles.
>
> Now the alloc flag may not be specified correctly in the other cases
> Additional tests to see whether the alloc flag is correctly passed for
> [GS}etScrollBarInfo and EnableScrollBar can be added.
>
> Would such tests address your concerns?

No, what you'd need is a test that shows that calling a function that
doesn't create a scrollbar (alloc=FALSE) suddenly starts to create one
if WS_[HV]SCROLL is set. To test this meaningfully you'd need to set the
style by hand, not at window creation.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list