C_ASSERT portability fixes and simplification [PATCH 1/2]

Alexandre Julliard julliard at winehq.org
Mon May 11 05:33:41 CDT 2009


Gerald Pfeifer <gerald at pfeifer.com> writes:

> This patch moves these into main() in main.c, which has several 
> advantages:
>
>  1. The asserts are only evaluated once, not for every #inclusion
>     of request.h, which simplifies/speeds up the compilation.

It doesn't make any difference, that stuff is inside a #ifdef.
Also it's auto-generated, so moving it manually won't help.

>  2. More importantly, these were the only occurences of C_ASSERT at
>     file level.  By moving these at function level use thereof becomes
>     consistent which will allow the fix from PATCH 2/2 to work at all.

C_ASSERT is supposed to work at the file level too.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list