Andrew.Talbot at talbotville.com
Sat May 23 11:29:55 CDT 2009
Francois Gouget wrote:
> So dlls/rsaenh/mpi.c defines 13 functions that are only used there. So
> they could be made static by tweaking mpi.c and tomcrypt.h.
> However my understanding is that this files has been imported in Wine
> from another project so maybe it's not a good idea to diverge much from
> What do you think?
> Should we just leave them as is?
I made a few of the functions in mpi.c static a while back, but stopped when
there was a bug report (http://bugs.winehq.org/show_bug.cgi?id=17406)
that seemed consequential but turned out to be apparently due to a bug gcc.
Also one of my patches to this file was rejected, which I didn't follow up,
but it may have been due to the fact that there are comments to each
function in both tomcrypt.h and mpi.c, and I tried to form combined versions
in the latter.
More information about the wine-devel