advapi32/tests: Skip tests for ACL file info if ACL info not stored (try 2)

Paul Vriens paul.vriens.wine at gmail.com
Wed Nov 18 03:12:45 CST 2009


On 11/18/2009 09:54 AM, Austin Lund wrote:
> +    TCHAR volumepathname[50];

Please don't use TCHAR's.

> +    BOOL testacl = FALSE;
> +    DWORD filesystemflags;
>
>       if (!pGetSecurityInfo)
>       {
> @@ -3143,6 +3146,13 @@ static void test_GetSecurityInfo(void)
>           return;
>       }
>
> +    if (GetVolumePathName(myARGV[0], volumepathname, 50)&&
> +        GetVolumeInformation(volumepathname, NULL, 0, NULL, NULL,&filesystemflags, NULL, 0)&&
> +        (filesystemflags&  FILE_PERSISTENT_ACLS))
> +    {
> +        testacl = TRUE;
> +    }

GetVolumePathName is not available before W2K so you should use 
GetProcAddress here and bail out or skip() if the function is not 
available. It's also probably better to use the explicit A-versions for 
both calls.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list