Whitespace cleanups

Nikolay Sivov bunglehead at gmail.com
Wed Nov 25 08:55:30 CST 2009


Nate Gallaher wrote:
> I'm looking at working on a new area of wine (for me) and the file I'm 
> going to be working
> with is rife with whitespace issues.  Literal tabs are sprinkled 
> around and the 80-col limit
> has been broken badly and often in easily fixable ways.  I'm wondering 
> what the acceptable
> approach is to these issues.
>
> I'd like to fix these issues before I start submitting functional 
> patches.  My question is this:
> Is it acceptable to fix the whole file in one patch (80-cols),
No.
> or should I just fix the
> one function I'm planning on touching?   Or should I grit my teeth and 
> ignore the style issues
> entirely?
Yes, in most cases. If you plan to rework the whole file with functional 
patches feel free to touch
formatting a bit. The common rule is to preserve existing format and 
remove things like spaces before
tabs or trailing spaces (the rest is done while committing automatically).

What file are you talking about?




More information about the wine-devel mailing list