Fixing the kernel32:actctx tests on Vista+

Jacek Caban jacek at codeweavers.com
Wed Nov 25 12:26:36 CST 2009


Paul Vriens wrote:
> On 11/25/2009 05:39 PM, Jacek Caban wrote:
>> Hi Paul,
>>
>> Paul Vriens wrote:
>>> Hi Jacek,
>>>
>>> You are the original author of these tests. Is there any reason the
>>> "test3.manifest" name is reused?
>>>
>>> The tests currently crash (intermittently on some) on Vista+ and with
>>> the attached patch things seem to get better. I'm just renaming one of
>>> the manifest files so there are no duplicates in these tests.
>>
>> I don't remember much about these tests, but looking at the code I don't
>> see any reason to reuse the name, so your patch looks good for me.
>
> Well, it was 2007 ;)
>
> Btw. another patch (see attached patch2) works as well and is 
> basically the same thing that Ge did back in September to these same 
> tests.
>
> So both work fine. Any favors for one over the other?

Both seem good for me. I think that a new file name is slightly better, 
because it feels safer than cheating cache mechanisms.


Jacek



More information about the wine-devel mailing list