[comctl32/tests] Fix some test failures

Nikolay Sivov bunglehead at gmail.com
Thu Oct 1 07:58:22 CDT 2009


Paul Vriens wrote:
> On 10/01/2009 02:03 PM, Nikolay Sivov wrote:
>>> The first and last character show up 'underneath' the prev/next
>>> buttons and the control is smaller than in US-English. This is because
>>> the day acronyms are only 2 characters.
>> You're testing on Windows system?
>
> Yes, this was on Windows XP.
Ok, I'll try to fix it someday.
>
>>
>> In git abbreviated day names use locale data already, so it should be
>> smaller in Wine too.
>>>
>>> So the patch is not correct as it doesn't cover all cases (yet).
>>>
>> It could be fixed with GetLocaleInfo() but it complicates test of 
>> course.
>
> Well, yes. Are you going to go further with this or should I "perfect" 
> at least the tests?
Yes, please. If a problem is only in rectangle orders it's very simple 
to fix (test for yyyy in returned locale data). I suggest not to drop 
tests yet, we'll probably want to drop them later when trying probable 
dpi-dependent failures.




More information about the wine-devel mailing list