kernel32/tests: Pass test on error code returned by Windows 7

Dmitry Kislyuk dimaki at rocketmail.com
Sun Oct 4 22:09:31 CDT 2009



--- On Sun, 10/4/09, Paul Vriens <paul.vriens.wine at gmail.com> wrote:

From: Paul Vriens <paul.vriens.wine at gmail.com>
Subject: Re: kernel32/tests: Pass test on error code returned by Windows 7
To: dimaki at rocketmail.com
Cc: wine-devel at winehq.org
Date: Sunday, October 4, 2009, 4:20 AM

On 10/04/2009 09:10 AM, Dmitry Kislyuk wrote:
>> +    ok( GetLastError() == 0xdeadbeef || GetLastError() == 2 /* Win 7 */,
>> +        "expected 0xdeadbeef or 2, got %d\n", GetLastError());

>Don't use magic numbers, ERROR_FILE_NOT_FOUND would be better.

>-- Cheers,

>Paul.

Hi Paul,

 All of the tests in this group of tests are the same way. Magic
numbers instead of defines. I wanted to stay consistent with that. 





If Alexandre doesn't apply it I will resend with using ERROR_FILE_NOT_FOUND per your suggestion.

Thank you for looking at my patch.

Dmitry




      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091004/dee6260c/attachment.htm>


More information about the wine-devel mailing list