Fixing bug #2181, standard EDIT class extra value

[Julius Schwartzenberg]

Dmitry Timoshkov wrote:
> "Julius Schwartzenberg" <julius.schwartzenberg at gmail.com> wrote:
> 
> 
> This obviously won't work for 64-bit. I'd suggest to make extra
> 2 * sizeof(void *). and add a comment about compatibility.
> 
> 
> ok(cls.cbWndExtra > sizeof(void *), "blah ...\n") doesn't require
> any intermediate variables.

Thanks for your feedback! I turns out however that Civilization II 
crashes with anything other than 6, so I used an IFDEF to check for 
64-bit as advised on IRC. The 64-bit version of Windows XP returns 8 
instead of 6 and Civilization II crashes at exactly the same point as 
Wine in it.

I've attached a new version and split the test and the patch. The test 
will fail on 64-bit Windows XP however, just like Civilization II. What 
is the best way to cope with this?

I also wondered whether it wouldn't be good to also test the extra 
values of the other standard classes instead of just the edit class. I 
created a table which shows all the return values for different Windows 
versions & Wine:
http://haar.student.utwente.nl/~julius/extra_value_table

To my eyes it seems the edit class is the only candidate that needs a 
test, but maybe someone more experienced could judge the table. In case 
other classes may also cause problems I will also add tests for those.

Julius
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-for-bug-2181.-Changes-the-extra-value-of-the-stan.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091007/5d67b3cf/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-The-test-passes-on-win98-winxp.-It-fails-on-WinXP-64.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091007/5d67b3cf/attachment-0001.txt>