[PATCH 2/2] mshtml: Reimplement HTMLLocation::get_pathname

Jacek Caban jacek at codeweavers.com
Fri Oct 16 12:54:42 CDT 2009


Andrew Eikum wrote:
> Jacek Caban wrote:
>> -    hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf, 
>> sizeof(buf), &size, 0);
>>
>> Please don't remove it. Using pluggable protocol has a visible on 
>> application and I've tested that it really should be called when I 
>> implemented it (altaught there is no test for it in Wine).
>>
>> Jacek
>
> I can fix that and resend.  Did you test any other IHTMLLocation 
> getters for this behavior?  Seems inconsistent for just one to cause a 
> visible effect like that.

No, I didn't test it. It's quite tricky as we'd have to register a 
pluggable protocol in htmllocation.c. I'd expect that other functions 
use pluggable protocol, but your implementation looks acceptable unless 
we'd find a need for changing it (I hope to use IUri someday which would 
solve such problems for us).

Thanks,
    Jacek



More information about the wine-devel mailing list