winecoreaudio: Quiet a noisy FIXME.

Peter Dons Tychsen donpedro at tdcadsl.dk
Fri Oct 16 22:26:44 CDT 2009


On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote:
> +    static int once;
> +
> +    if (!once++) FIXME("independent left/right volume not implemented
> (%f, %f)\n", left, right);

I know it is a detail, but is it not a bit misleading having a variable
called "once" when it will trigger the code every 4294967295th time.

Its not 100% wrong, but only 0.000000023% wrong :-)

More correct would probably be:

static int once;
if(!once) {bla...bla; once=1};

Thanks,

/pedro



More information about the wine-devel mailing list