Trying to fix some setupapi tests on Win9x/WinMe

[Paul Vriens]

On 10/20/2009 10:37 AM, Hans Leidekker wrote:
> On Tuesday 20 October 2009 10:07:07 am Paul Vriens wrote:
>
>> In an effort to get everything green I'm trying to fix some long
>> standing setupapi test failures.
>>
>> In one of the tests, test_SetupDecompressOrCopyFile() in misc.c, we call
>> SetupDecompressOrCopyFileA a few times. One of them fails as the target
>> file is still open and doesn't allow reading from it
>> (ERROR_SHARING_VIOLATION).
>
> Looking at
> http://test.winehq.org/data/9390bc921e012888d488e8314a4379bc76e2c4d4/98_gvg-w98se/setupapi:misc.html
>
> the problem seem to center around LZ compression. ERROR_READ_FAULT is

I traced the compare_file_data() function and the target file couldn't 
be opened (sharing error) and that's why the tests on line 554 failed. 
Don't know why SetupDecompressOrCopyFileA returns ERROR_READ_FAULT 
though in that next call.

> returned before the sharing violation so it looks like 9x did not clean
> up properly there.

You mean just in the setupapi tests before that error? It doesn't 
explain however why it only fails in some circumstances.

>
> I would suggest to skip the LZ related tests on 9x.

That's the easy way out ;). I do want to try to get to the bottom of 
this. We have many tests out there that fail intermittently, probably 
because of us not cleaning up properly or when running the tests a 
second time on a non-clean system.

-- 
Cheers,

Paul.