[PATCH 1/2] Patch for bug 20227

Juan Lang juan.lang at gmail.com
Wed Oct 21 10:18:00 CDT 2009


Hi Nate,

the subject line isn't specific enough.  We'd prefer you put a brief
description of the change, rather than the bug that motivated it.
E.g. your git commit tag for this, "Add tablename tracking to
VIEW_find_column.", would be better.  For your patch 2/2, you used
"Test for bug 20227" as the git commit, which really isn't descriptive
enough.

Thanks.

(Also, nit:
> irregardless of any tablename modifier.
irregardless is not a word.  You probably mean either regardless or
irrespective.)
--Juan



More information about the wine-devel mailing list