[PATCH 5] winmm/tests: Add MCI waveaudio tests.

[Reece Dunn]

2009/10/26  <Joerg-Cyril.Hoehle at t-systems.com>:
> Hi,
>
>> +/* Some tests hang or crash Wine. Enable once fixed. */
>> +#define FULL_TEST 0
>
>>Please don't introduce dead code. If the tests really can't work then
>>don't add them at all until you have the corresponding fixes.
>
> Will do.  Although I'd very much prefer having tests than no tests.
> I've been fixing MCI regressions that were as old as 2001 that would
> hopefully not have occured if there had been tests in the first place.
> The #if FULL_TEST is very useful when compiling on MS-W* to immediately
> spot what Wine should eventually do, and as direction for others
> when I'll be gone.
>
> How do other people deal with that situation?
>  - use some patch manager, e.g. quilt?
>  - maintain seprate test files for running under MS-W*?
>  - ignore, write no tests and wait for bugs.winehq?
>  - ...?

If the tests are returning incorrect results in Wine, the practice
when writing the tests is to add todo_wine before the ok statement.
Once the fix has been added, the todo_wine bit can be removed. E.g.

before fix:

    todo_wine
    ok(hr == S_OK, "should return S_OK, got: %08x", hr);

after fix:

    ok(hr == S_OK, "should return S_OK, got: %08x", hr);

Alternatively, you can fix a Wine bug and add the test for it in the
same patch (or with the tests added in the next patch in the series).
These should ideally be tested on Wine and at least one Windows
platform. Other platforms will be picked up on the tests.winehq.org
site.

- Reece