[PATCH 01/12] d3d10: Fix a HeapFree() in d3d10_effect_Release().

Henri Verbeet hverbeet at gmail.com
Wed Oct 28 05:43:03 CDT 2009


2009/10/28 Stefan Dösinger <stefandoesinger at gmx.at>:
> Do we have any tests for the As* behavior?
>
> Most conversions don't make any sense, so if the app wants a constant buffer
> as a render target view returning a null obj  is probably a sane thing. But
> ::AsString potentially makes sense for all objects, maybe in a similar way
> Object::ToString is used to obtain a String for debug output in Java.
>
> Also, do we know what happens if the object is "converted" back to its
> original state? E.g.
>
> constant_buffer = render_target_view::AsConstantBuffer();
> render_target_view2 = constantBuffer::AsRenderTargetView?
>
> As far as I understand it, your code would return a null rt view. Is this
> correct?
>
The patches are correct, I wrote tests for this for commits
508635ac4c290b00bd2aa97026e627a50d3c4cee,
58fcb06c07cbe4fd9cd94dc138d625cf08b82fb7 and
fbbbdc09a591d7e8deae3830400ac7ad1d2fca8e. I didn't submit those
though.



More information about the wine-devel mailing list