[PATCH 1/7] dpwsockx: Stub implementation
Ismael Barros²
razielmine at gmail.com
Tue Sep 1 05:17:43 CDT 2009
dpwsockx is not used by any application, only by us in dplayx, so it's
pretty safe to assume we won't pass any invalid parameter, as all the
parameters passed by applications are already checked for validity in
dplayx.
On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet<hverbeet at gmail.com> wrote:
> 2009/9/1 Ismael Barros <razielmine at gmail.com>:
>> ---
>> dlls/dpwsockx/Makefile.in | 2 +-
>> dlls/dpwsockx/dpwsockx_main.c | 164 ++++++++++++++++++++++++++++++++++++++++-
>> 2 files changed, 163 insertions(+), 3 deletions(-)
>>
> This patch seems to assume the application will never pass NULL for
> "data", is that safe to assume? If applications aren't allowed to pass
> NULL it's ok to crash, although it might make your life simpler if it
> isn't inside a TRACE/FIXME.
>
>
>
More information about the wine-devel
mailing list