CPPCheck for Sept 8th

[Nicolas Le Cam]

2009/9/9 chris ahrendt <celticht32 at yahoo.com>:
> Nicolas Le Cam wrote:
>> 2009/9/9 Alexandre Julliard <julliard at winehq.org>:
>>> chris ahrendt <celticht32 at yahoo.com> writes:
>>>
>>>> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd
>>> This is the only one that looks a real bug, all the rest are false
>>> positives. Please filter them out from future reports.
>>>
>>> --
>>> Alexandre Julliard
>>> julliard at winehq.org
>>>
>>>
>>>
>>
>> Not necessary false positives. Errors in dlls/msvcrt/tests/file.c, for
>> example, are real but expected errors, as it's the purpose of the test
>> to see how it behaves on Windows in such situation.
>>
>
> So continue to send everything then?
> Since I have been running them the size has not really been that
> large... just let me know what you want me to send and I will
> send it in...
>
> Chris
>

This was just a clarification so that you won't report everything as
false positives to cppcheck devs, only real ones :
[/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible
error) Memory leak: mem
[/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible
error) Array index out of bounds
[/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible
null pointer dereference: dmW - otherwise it is redundant to check if
dmW is null at line 272
[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd
[/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd

IMHO, those are potential leaks :
[/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:146]: (error)
Resource leak: mixer
[/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:208]: (error)
Resource leak: mixer

Basically, filter out everything except the one Alexandre pointed out.
You can also exclude tools and tests subdirectories.

-- 
Nicolas Le Cam