bitblt.c - GdiAlphaBlend : Check for NULL Pointer

[Nikolay Sivov]

Markus Stockhausen wrote:
> Am Freitag, den 11.09.2009, 01:17 +0400 schrieb Nikolay Sivov:
>   
>>
>
> Phew, in 3 days from 0 to 100. Too much for me. If I get it right, there
> are two things to do.
>
> 1. I should optimize my patch and remove unnecessary dcSrc checks.
>   
Actually, yes. After your patch this check:
---
if (dcSrc) update_dc( dcSrc );
---
is useless.
> 2. A testcase is needed to prove the correct function behaviour in
> Windows and Wine. The tastcase is already available but not commited
> yet.
>   
Yes, testcase is trivial. I also did some visual tests and saw now 
difference on destination
dc calling this with source == NULL.
> For me this means:
>
> 1. Wait for testcase implementation.
> 2. Create new patch and test under Wine
> 3. Ask someone to do test under Windows
> 2. Resent patch to mailing list.
>
> Thanks for your patience.
>
> Markus
>   
Just correct your patch (as you mentioned before), include simple 
testcase and resend.
So nothing to wait for.

Basic test shows it doesn't crash on Windows and doesn't change last 
error - I already
check this on XP and it passes.