bitblt.c - GdiAlphaBlend : Check for NULL Pointer

Paul Vriens paul.vriens.wine at gmail.com
Fri Sep 11 02:24:53 CDT 2009


On 09/11/2009 09:13 AM, Markus Stockhausen wrote:
> Am Freitag, den 11.09.2009, 09:04 +0200 schrieb Paul Vriens:
>> Hi Markus,
>>
>> One I see is a style issue with the if statement. There shouldn't be a
>> space after the opening and before the closing bracket.
>>
>> Another thing (style again) is that maybe it's nicer to return FALSE
>> instead of ret (as is done throughout this file).
>>
>
> Resending the desired changes and hoping to see them finding their way
> into git ...
>
> Best regards.
>

Patches that you want to have committed should go to wine-patches.

I did found another small issue though:

line 532: "dcSrc ? dcSrc->physDev : NULL" this should be replaced as well.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list