[PATCH 2/2] dpwsockx: Implementation of Open callback
razielmine at gmail.com
Tue Sep 15 11:31:13 CDT 2009
On Mon, Sep 14, 2009 at 12:46 AM, Vitaliy Margolen
<wine-devel at kievinfo.com> wrote:
>> It's a way to tell between abruptly ending the thread due to an error,
>> and ending the thread gracefully.
> That makes no sense to me. You have no other point of exit from the loop.
> Using goto for no good reason is always a bad thing.
Actually I'm considering dropping that code and using nonblocking
sockets with WSARecv/From() and a callback, which would make the code
much simpler, as I wouldn't have to manage my own threads.
However the blocking approach (recv/from()) seems to be more popular
in the codebase; is there any drawback I'm not aware of, or using
nonblocking sockets is okay?
More information about the wine-devel