[(try 3) 3/3] opengl32/tests: Improve test for wglMakeCurrent.

Rico Schüller kgbricola at web.de
Sat Sep 19 06:15:32 CDT 2009


Am 19.09.2009 12:46, schrieb Paul Vriens:
> On 09/19/2009 12:29 PM, Rico Schüller wrote:
>> ---
>> dlls/opengl32/tests/opengl.c | 10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>>
>
> +    ret = wglMakeCurrent( NULL, NULL );
> +    ok( !ret, "wglMakeCurrent failed\n" );
>
> shouldn't that message read "wglMakeCurrent succeeded" ?
Yes, probably something like "wglMakeCurrent succeeded, but should 
fail!" is really a better solution.

>
> If you are testing the last error it's usually a good idea to set the 
> last error before the call (aka "SetLastError(0xdeadbeef)").
>
I haven't called SetLastError() before, because it's not done in the 
rest of the tests in dlls/opengl32/tests/opengl.c . But if it is usually 
a good idea, I could change that, too.



More information about the wine-devel mailing list