winmm: MCI system commands are not eligible for auto-open. (try 2)
dmitry at codeweavers.com
Mon Apr 12 23:01:25 CDT 2010
<Joerg-Cyril.Hoehle at t-systems.com> wrote:
> >Since there is no neither todo_wine statements in the tests, nor test failures
> >under Wine that means that both the tests and the patch are not OK.
> What has Wine to say when talking about the correctness
> of tests? Only native dictates what the test result should be.
Of course the tests are suppose to show the behaviour of Windows.
> The emerging rule is: "no notification in case of error", and there's even a
> specific test case about the MCI sound string command in the tests.
And another rule is that the patch which changes the behaviour of an API
needs to have an appropriate test case which does not pass before the patch
(i.e. has the todo_wine around it), and passes after the patch (i.e. the patch
removes the corresponding todo_wine). Your patch doesn't qualify for that.
More information about the wine-devel