winex11: add support for 32-bit DDBs

[Erich Hoover]

On Thu, Apr 15, 2010 at 7:04 AM, Erich Hoover <ehoover at mines.edu> wrote:

> On Thu, Apr 15, 2010 at 2:22 AM, Roderick Colenbrander <
> thunderbird2k at gmail.com> wrote:
>
>> I can't see the screenshot well but that's notepad? What display
>> drivers are you using?
>>
>> Roderick
>>
>> On Thu, Apr 15, 2010 at 3:36 AM, Erich Hoover <ehoover at mines.edu> wrote:
>> > I noticed a problem with the icons in Wine when alt+tabbing today.
>> After
>> > doing a regression test it appears that commit
>> > c29cf0591976f96c3adb30c3c3b6db59f4983251 results in pixmaps that do not
>> > always display properly when alt+tabbing (see attached screenshot).
>> >
>>
>
> That's the notepad window in the compiz alt+tab dialog (everything except
> the window icon gets scaled).  The key feature is that in the bottom right
> corner the icon for the window is really messed up (black with a few dots of
> color).  It's also worth noting that the window icon does not display in the
> gnome taskbar at all after this patch, just a generic "this program has no
> icon" icon.  I'm using the nVidia driver version 185.18.36.
>

I looked into this a little and it appears like it's necessary to use the
extended window manager hint _NET_WM_ICON to use 32-bit window icons.  I've
whipped up a small patch (attached) that does this and it fixes the problem
I'm seeing (both with alt+tab and in the gnome taskbar), does this solution
appear acceptable?

Erich Hoover
ehoover at mines.edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100415/ed26fc94/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winex11.drv-Set-the-_NET_WM_ICON-for-32-bit-window-i.patch
Type: text/x-diff
Size: 2995 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100415/ed26fc94/attachment.patch>