shell32: Fix tests to apply to Vista+
André Hentschel
nerv at dawncrow.de
Fri Apr 23 08:20:25 CDT 2010
Nikolay Sivov schrieb:
> On 4/23/2010 16:56, André Hentschel wrote:
>> ---
>> dlls/shell32/tests/shlfolder.c | 5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/dlls/shell32/tests/shlfolder.c
>> b/dlls/shell32/tests/shlfolder.c
>> index f63bf6e..634c3d3 100644
>> --- a/dlls/shell32/tests/shlfolder.c
>> +++ b/dlls/shell32/tests/shlfolder.c
>> @@ -2048,7 +2048,10 @@ if (0)
>> ok(hr == S_OK, "failed %08x\n", hr);
>>
>> ret = pILIsEqual(pidl1, pidl2);
>> - ok(ret == TRUE, "expected equal idls\n");
>> + todo_wine
>> + ok(broken(ret) ||
>> + !ret, /* Vista+ */
>> + "expected different idls\n");
>> pILFree(pidl1);
>> pILFree(pidl2);
>>
>>
> There's no point to silence this. We need to figure out what's this pidl
> about on Vista+, e.g. dump it data and then probably review Wine
> handling of this.
My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say).
--
Best Regards, André Hentschel
More information about the wine-devel
mailing list