shell32: Fix tests to apply to Vista+

Paul Vriens paul.vriens.wine at gmail.com
Fri Apr 23 11:46:42 CDT 2010


On 04/23/2010 06:30 PM, André Hentschel wrote:
> Juan Lang schrieb:
>>> My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say).
>>
>> Any test that allows all possibilities, as your patch does on Windows,
>> is worthless.  That implies that it should be investigated, and, if
>> it's truly a meaningless test, then remove it.
>> --Juan
>
> It still has two benefits applying the patch: it states its a todo on wine and it documents the old behavior of windows as broken.

But who guarantees that the old behavior is broken and not the new one?

I'm with Juan and Nikolay on this one, we need more investigation.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list