shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]
Ilya Basin
basinilya at gmail.com
Sat Apr 24 05:13:29 CDT 2010
PV> Hi Ilya,
PV> In your last email on wine-devel about this subject you mentioned adding
PV> some extra tests. There was at least some communication with you and the
PV> author of that piece you are now removing. The reason for that piece was
PV> shown in a code-snippet he gave and adding tests for that specific case
PV> would be worthwhile I think.
Hi Paul. Yore're right, I forgot.
IB> Add a new verb that has '%*' in it. I put the reply from M.Fuchs in
IB> the bottom. It seems that it was related to .lnk handling.
Then postponing till my next slack period, the more so I got another
e-mail:
=== W7PROX64 (32 bit shlexec) ===
No test failures found
=== W7PROX64 (64 bit shlexec) ===
shell32:
shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2
shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2
shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2
shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2
shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2
Strange, isn't it? I wonder if the tests succeeded without my patch.
I was wrong in the following part:
IB> But currently I'm more worried by
IB> http://bugs.winehq.org/show_bug.cgi?id=19385
IB> ( the 'wine start' launcher does not open MS Office documents that
IB> have spaces in their path )
IB> If the <verb>\command doesn't contain '%', e.g.
IB> '"C:\PROGRA~1\MICROS~2\OFFICE11\WINWORD.EXE" /n /dde'
IB> it's argyfied incorrectly
IB> Now there's no test verb without '%', I think I should add it
IB> and add related tests.
Later I reviewed the code and learned that this was
unrelated to the bug with lpFile parsing.
I sent another patch, so the bug 19385 is fixed now.
We can still add more DDE tests, but, I repeat, it's not related to
the current topic.
--
More information about the wine-devel
mailing list