[PATCH 2/7] d3dx9_36/tests: Added HLSL test suite

Dan Kegel dank at kegel.com
Wed Aug 25 11:11:34 CDT 2010


Henri wrote:
> You still have basic formatting errors like trailing spaces, mixing
> tabs and spaces, inconsistent "*" placement, etc.
> ... unnecessary cast...
> wine-patches reviews are supposed to catch non-trivial interactions with
> other parts of the code, not trivial whitespace errors.

Looking at http://wiki.winehq.org/SubmittingPatches, I didn't see a nice,
concise checklist of things to check for, so I added one at the top, and
linked to Henri's post.  Improvements welcome.
- Dan



More information about the wine-devel mailing list