[PATCH 5/6] mshtml: Added IHTMLWindow2::open test.

Jacek Caban jacek at codeweavers.com
Sun Dec 12 10:35:47 CST 2010


Hi Paul,

On 12/12/10 12:30 PM, Paul Vriens wrote:
> Hi Jacek,
>
> On 06/14/2010 02:20 AM, Jacek Caban wrote:
>> ---
>>   dlls/mshtml/tests/htmldoc.c |  100
>> ++++++++++++++++++++++++++++++++++++++++++-
>>   1 files changed, 98 insertions(+), 2 deletions(-)
>>
>
> Some of these tests fail on IE6 SP1:
>
> http://test.winehq.org/data/tests/mshtml:htmldoc.html
>
> What would be the best approach to fix these? We can add a broken() 
> for the
>
> 3577     todo_wine
> 3578     ok(new_window == NULL, "new_window != NULL\n");
>
> but what about the
>
> 3582     todo_wine
> 3583     CHECK_CALLED(EvaluateNewWindow);
>
> introduce a CHECK_CALLED_BROKEN also in this file?

I think that win_skip mechanism will be more appropriate here, as these 
machines for some reason don't support INewWindowManager. At some point 
we will go back to implementing it and then we will need more tests that 
will better be skipped on those IEs.

My patch proposal is currently running on winetestbot:
https://testbot.winehq.org/JobDetails.pl?Key=7560

Thanks,
     Jacek




More information about the wine-devel mailing list