[PATCH 4/6] urlmon: Add some error handling to the http protocol.

David Hedberg david.hedberg at gmail.com
Wed Dec 22 07:17:20 CST 2010


Hi Jacek,

On Wed, Dec 22, 2010 at 13:07, Jacek Caban <jacek at codeweavers.com> wrote:

>> +    if(security_problem) {
>> +        hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink,
>
> You shouldn't need the cast here.
>

I get warnings if I leave the casts out though, and I can't see any
obvious problem with the declarations. Any ideas?

> Please add some real tests. At least a connection to an invalid certificate
> should be easy to achieve.
>

I'll look into adding some better tests.

Thanks,
David



More information about the wine-devel mailing list