[PATCH 4/6] urlmon: Add some error handling to the http protocol.
jacek at codeweavers.com
jacek at codeweavers.com
Wed Dec 22 08:52:31 CST 2010
On 12/22/10 2:17 PM, David Hedberg wrote:
> Hi Jacek,
> On Wed, Dec 22, 2010 at 13:07, Jacek Caban<jacek at codeweavers.com>
wrote:
>>> + if(security_problem) {
>>> + hres =
IUnknown_QueryService((IUnknown*)This->base.protocol_sink,
>> You shouldn't need the cast here.
> I get warnings if I leave the casts out though, and I can't see any
obvious problem with the declarations. Any ideas?
I've read your patch wrongly, sorry. Please avoid using
IUnknown_QueryService. It's an ugly named helper function and it causes
confusions like mine. Explicitly QIing for IServiceProvider and calling
QueryService on it is the way to go.
Cheers,
Jacek
More information about the wine-devel
mailing list