[PATCH 4/5] ddraw: Add depth clamp tests.

Paul Vriens paul.vriens.wine at gmail.com
Tue Feb 9 10:32:38 CST 2010


On 01/26/2010 06:31 PM, Henri Verbeet wrote:
> +    color = getPixelColor(device, 150, 150);
> +    todo_wine ok(color_match(color, 0x00ffffff, 1), "color 0x%08x.\n", color);

Hi Henri,

This particular test fails on some VMware and VirtualBox boxes. We've 
been through this before about whether broken() is appropriate or not.

The attached patch adds an explicit broken color value instead of some 
color_match().

Not sure what's the best way though.

We don't have many test runs on real Windows for these new tests so I 
can't be a 100% sure if it's just VMware/VirtualBox. Some real boxes 
have run the ddraw:visual tests but not these new ones as they bailed 
out because of other issues.

Any thoughts on this one?

-- 
Cheers,

Paul.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100209/a6382efc/attachment.asc>


More information about the wine-devel mailing list