mciwave: Stub a boundary case in Save.
Dmitry Timoshkov
dmitry at codeweavers.com
Tue Feb 16 06:45:05 CST 2010
<Joerg-Cyril.Hoehle at t-systems.com> wrote:
> This will allow me to enable one more testcase when I'll eventually
> submit the long awaited update to mciwave tests.
> - if (dwFlags & MCI_WAIT)
> - {
> - FIXME("MCI_WAIT not implemented\n");
> + if (wmw->hFile == 0) {
> + FIXME("Save file with zero-length sample\n");
> + return MCIERR_INTERNAL;
> }
> - WAVE_mciStop(wDevID, 0, NULL);
> + WAVE_mciStop(wDevID, MCI_WAIT, NULL);
Please don't change the indentation style of the code. Also, it's
not clear to me why you have removed the MCI_WAIT fixme, added MCI_WAIT
to mciStop, and treat hFile == 0 as a zero-length sample.
--
Dmitry.
More information about the wine-devel
mailing list