[PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

Christian Costa titan.costa at wanadoo.fr
Wed Feb 17 06:22:09 CST 2010


Henri Verbeet a écrit :
> On 17 February 2010 11:47, Christian Costa <titan.costa at wanadoo.fr> wrote:
>   
> It should use debugstr_an() in the first place. You could have a go at
> splitting it into separate lines if needed after that, but I can't
> think of a whole lot of cases where the comments are really useful.
>
>
>
>
>   
I don't see your point using debugstr_an. My code does all the needed job.
Wrt comments, having displayed the comments that explain the assembly code
is not uninteresting at all imo. I'm tempted to keep then displayed.





More information about the wine-devel mailing list