[PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

Henri Verbeet hverbeet at gmail.com
Wed Feb 17 06:57:11 CST 2010


On 17 February 2010 13:22, Christian Costa <titan.costa at wanadoo.fr> wrote:
> I don't see your point using debugstr_an. My code does all the needed job.
It's unvalidated external data, special characters should be escaped.

> Wrt comments, having displayed the comments that explain the assembly code
> is not uninteresting at all imo. I'm tempted to keep then displayed.
>
I have *never* used the comments to fixed a bug, or seen particularly
interesting ones, for that matter. Regardless, if it works for you
that's fine.



More information about the wine-devel mailing list