[PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

Reece Dunn msclrhd at googlemail.com
Wed Feb 24 05:12:31 CST 2010


On 24 February 2010 11:06, Alexandre Julliard <julliard at winehq.org> wrote:
> Reece Dunn <msclrhd at googlemail.com> writes:
>
>> NOTE: A check for integer overflow would be `position.low + move.low <
>> position.low`, but there are no current tests to say if integer
>> overflow is handled (and how it is handled) here in the tests.
>> Therefore, the simplest implementation is just to remove the previous
>> check.
>
> It may be the simplest, but the right way is to add such a test and
> figure out the appropriate behavior.

Will do -- that was next on my things to do.

Do I need to do that first before this change, or after it?

- Reece



More information about the wine-devel mailing list