Use GCC's -Wlogical-op if possible

Henri Verbeet hverbeet at gmail.com
Mon Jan 4 11:07:23 CST 2010


2010/1/4 André Hentschel <nerv at dawncrow.de>:
> I dont see a reason to take that warning serious, as its not a problem in any case. in kernel32 it just  happens because we use a Macro. Taking that case(v==1) out of the Macro leads to harder readable code.
> So IMHO i would not make -Wlogical-op the default.
>
Not using that macro at all would be even more readable. I'm probably
missing something obvious, but it seems to just do a wsprintfW() with
"#%d" as format.



More information about the wine-devel mailing list