[PATCH] shell32: handle bad menu handle (Coverity)

Nikolay Sivov bunglehead at gmail.com
Sat Jan 9 08:04:03 CST 2010


On 1/9/2010 16:59, Marcus Meissner wrote:
> Hi,
>
> handle "invalid menu" return -1.
>
> Ciao, Marcus
> ---
>   dlls/shell32/shlmenu.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>    

>   	nItem = GetMenuItemCount(hmDst);
> +        if (nItem == -1)
> +	  return uIDMax;
>    
Hi, Marcus.

Could you please add a test for that? It seems trivial.





More information about the wine-devel mailing list