wmc: Fix symbol was not declared and using plain integer as NULL pointer sparse warnings.
Jacek Caban
jacek at codeweavers.com
Thu Jan 21 07:42:25 CST 2010
On 1/21/10 2:33 PM, Rob Shearman wrote:
> 2010/1/21 Jacek Caban<jacek at codeweavers.com>:
>
>> Hi Rob,
>>
>> On 1/21/10 12:57 PM, Rob Shearman wrote:
>>
>>> ---
>>> tools/wmc/wmc.c | 8 +++++---
>>> tools/wmc/wmc.h | 2 +-
>>> 2 files changed, 6 insertions(+), 4 deletions(-)
>>>
>>>
>> --- a/tools/wmc/wmc.h
>> +++ b/tools/wmc/wmc.h
>> @@ -65,7 +65,7 @@ extern node_t *nodehead;
>> extern lan_blk_t *lanblockhead;
>>
>> int mcy_lex(void);
>> -FILE *yyin;
>> +extern FILE *yyin;
>>
>>
>> It looks like it worked before your patch only because it's used only in
>> wmc.c, which means that it probably should be static.
>>
> It's used in mcl.c too:
> mcl.c: cptr = fgets(xlatebuffer, INPUTBUFFER_SIZE, yyin);
> mcl.c: if(!cptr&& ferror(yyin))
> mcl.c: n = fread(inputbuffer, 1, 8, yyin);
> mcl.c: if(!n&& ferror(yyin))
> mcl.c: t = fread(&inputbuffer[i], 2, 1, yyin);
> mcl.c: if(!t&& ferror(yyin))
>
I don't know how I missed that. I'm sorry.
Thanks,
Jacek
More information about the wine-devel
mailing list