Add support for arguments to -fprofile-* functions.

Peter Davies ultratwo at gmail.com
Thu Jul 1 13:39:11 CDT 2010


> Hi,
> sorry, but your patch is a bit ugly...
> please look at the code below /* determine if tihs switch is followed by a separate argument */ in winegcc.c and understand what it does.
> specially with next_is_arg, is_linker_arg, ....

I could set option_arg for semantic correctness.

> Also the following is senseless:
> +int strstartswith(const char * str, const char * start)
> +{
> +    return strstr(str, start) == str;
> +}

Are you objecting to function or the implementation? It is a simple
function that clarifies the code by making it self documenting,
implemented fairly efficiently in a performance wise undemanding
program.

Peter



More information about the wine-devel mailing list