[PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

Dmitry Timoshkov dmitry at codeweavers.com
Tue Jul 6 08:29:05 CDT 2010


Austin Lund <austin.lund at gmail.com> wrote:

> > This code is completely broken. An app can decide to not even pass these
> > messages to a subclassed richedit control.
> 
> I'm not sure how that's relevant because if the messages aren't passed
> then as long as a WM_NCCREATE is passed then the editor variable is
> initialised by this.

What happens if an application doesn't pass WM_NCCREATE?

> I'm reading this comment carefully for a suggestion as to how to "fix"
> things, but it seems totally obfuscated.

Editor should be unconditionally initialized if it's NULL, and WM_NCDESTROY
should be made an explicit case in the 'switch' statement.

-- 
Dmitry.



More information about the wine-devel mailing list