[Resend] Add '_ONCE' variants of DPRINTF, FIXME, WARN.

Mike Kaplinskiy mike.kaplinskiy at gmail.com
Sat Jul 17 20:48:50 CDT 2010


On Sat, Jul 17, 2010 at 1:29 AM, Max TenEyck Woodbury
<max at mtew.isa-geek.net> wrote:
> +#define WINE_FIXME_ONCE(args...) do { } while(0)
> +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE
I think you want WINE_FIXME_ONCE_ not WINE_FIXME_ONCE_ONCE_.

> +#define WINE_FIXME_ONCE(args...) do { } while(0)
> +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE
Ditto

> +#define __WINE_DPRINTF_ONCE(dbcl,dbch) /* FIXME */ \
> +    (!__WINE_GET_DEBUGGING(dbcl,(dbch)) || \
> +     (wine_dbg_log(__WINE_DBCL##dbcl,(dbch),__FILE__,"%d: ",__LINE__) == -1)) ? \
> +     (void)0 : (void)wine_dbg_printf
> +
Ask if you don't know how to do it. I don't think we bite too much :).
I have no idea what compilers need this instead of the versions for
GNU and SunPro. In fact, I don't actually know what compilers those
would be (clang may be one of them?). But in the worst case I would
suggest at least #error 'ing if someone uses __WINE_DPRINTF_ONCE on
these instead of falling back to non-once behavior.

> +#define WARN_ONCE_(ch)             WINE_WARE_ONCE_(ch)
typo

> +#define ERR_ONCE                   WINE_ERR_ONCEE
typo



More information about the wine-devel mailing list