[PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

[Oldřich Jedlička]

Hi Stefan,

On Thursday 22 July 2010 22:05:21 Stefan Dösinger wrote:
> Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička:
> > +    hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw, (void **)
> > &dd); +    ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed:
> > 0x%08x\n", hr);
> 
> This is redundant, lpDD is already an IDirectDraw interface.

You are right, I thought it is some default (=latest, V7) interface. I will 
change it.

> > +    hr = IDirectDraw_CreateSurface(dd, &ddsd, &surf, NULL);
> > +    ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface failed: 0x%08x\n", hr);
> 
> This test will fail before your 3/4 patch is in, so you'll have to use
> todo_wine for now, and remove in the patch that implements the correct
> behavior. You'll have to handle the NULL pointer that is returned in case
> of a failure.

The same is for my 2/4. I will add the todo_wine in 1/4 and 2/4 and remove 
them in 3/4 and 4/4.

Which NULL pointer do you mean? Does the todo_wine mean that the test reports 
problem and just continues (so that surf is NULL)?

Thanks,
Oldrich.