[1/5] gameux: Add initial implementation of gameux.dll
James McKenzie
jjmckenzie51 at earthlink.net
Fri Jul 23 20:22:53 CDT 2010
Dan McDonald wrote:
> On 07/21/2010 11:10 AM, André Hentschel wrote:
>
>> Am 21.07.2010 19:01, schrieb Mariusz Pluciński:
>>
>>> W dniu 19.07.2010 15:02, Henri Verbeet pisze:
>>>
>>>> 2010/7/18 Mariusz Pluciński<vshader at gmail.com>:
>>>>
>>>>> +static HINSTANCE hInstance;
>>>>>
>>>> This is unused.
>>>>
>>>> You're mixing tabs and spaces, and have a couple of trailing spaces.
>>>>
>>>> Also:
>>>>
>>>>> + * DllRegisterServer (OLEAUT32.@)
>>>>>
>>> The code of "my" regsvr.c is almost non-modified copy of the same
>>> file in oleaut32.dll implementation. If it's bad formatted, why it
>>> exists in official Wine code?
>>>
>> For the same reason why intentation patches are not accepted, because it makes the use of "git blame" hard.
>>
>
> git blame has a -w option. Does that not work very well?
>
> Dan
>
>
Although that is a good option, we don't want to know everyone who
touched a piece of code in many cases, just the last person. Also, the
output from that command is HUGE.
James McKenzie
More information about the wine-devel
mailing list