[PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

[Misha Koshelev]

Ok I am very very sorry email is clearly not my forte.

Linking same file in test and main dll: I am not aware of a precedent for
this but if there is one of course I would be glad to be shown otherwise.

Second comment: please pardon if I am misunderstanding but how is what you
suggest not simply moving the lookup table calculation from the helper
function which we will also use for, at the very least, the cylinder test,
inside the actual compute_sphere function itself?

Thank you
Misha

On Jul 26, 2010 8:40 PM, "Octavian Voicu" <octavian.voicu at gmail.com> wrote:

On Tue, Jul 27, 2010 at 4:15 AM, Misha Koshelev <misha680 at gmail.com> wrote:
> Why do you ask?
>
> Ar...
That's why I was asking, as I suppose you can't use functions from the
test in the implementation, nor have internal functions used in the
tests. Only way I see it is to have something like mesh_utils.[ch]
which is linked with both the dll and the test, but I'm not sure if
that's acceptable. Maybe someone else can answer that.

A little observation is that you don't really need to precompute both
tables, just the one for phi (if you compute sin and cos of current
theta outside the inner loop).

Octavian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100726/244dc13a/attachment.htm>