jscript: Added support for Function.arguments property.

Nicolas Le Cam niko.lecam at gmail.com
Tue Jul 27 07:16:52 CDT 2010


2010/7/27 Jacek Caban <jacek at codeweavers.com>:
>  On 7/27/10 12:18 PM,  (Marvin) wrote:
>>
>> Hi,
>>
>> While running your changed tests on Windows, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I might
>> be
>> wrong, but could you please double-check?
>> Full results can be found at
>> http://testbot.winehq.org/JobDetails.pl?Key=3956
>>
>> Your paranoid android.
>
> This is a problem that I change files in test directory that are stored in
> resources, so Test Bot doesn't know, which test should it run. Can we do
> something about it? There are a few options that come to my mind:
>
> - Add magic keyword that would be present in patch mail telling which tests
> should be ran
> - Detect that the patched file is not a test file and run all tests
> corresponding to dll or ignore the patch
> - Store a map associating such files with tests somewhere
>
> Jacek
>
>
>
If resource files are only used by one testset a simple option could
be to name it like the source file and change the testbot to handle
that :

--- a/lib/WineTestBot/Patches.pm        2010-07-27 13:58:41 +0200
+++ b/lib/WineTestBot/Patches.pm        2010-07-27 14:10:07 +0200
@@ -102,7 +102,7 @@
         my $FileType = "patch$1";
         my $BaseName = $2;
         my $TestSet = $3;
-        if ($TestSet =~ m/^(.*)\.c$/)
+        if ($TestSet =~ m/^(.*)\..*$/)
         {
           $TestSet = $1;
         }

-- 
Nicolas Le Cam



More information about the wine-devel mailing list