[PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

Andrew Eikum aeikum at codeweavers.com
Sat Jun 5 11:19:10 CDT 2010


> On 6/5/2010 19:09, Andrew Eikum wrote:
>> I'm not sure I follow.  As the tests in the patch show, QI is called up
>> to
>> two times, once for IPersist and once for IPersistFolder if the first
>> fails.  I can certainly add tests for returning different CLSIDs, though
>> that seems uninteresting to me since they all behave identically.
>>
> I mean, create different types of shellfolders, then test that function
> accepts them all. And a simple check that QI isn't called for
> IShellFolder, so
> argument expected to be IShellFolder pointer.

Argh, webmail clients are frustrating.  Here's the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shlwapi-Be-less-strict-on-which-type-of-IShellFolder.patch
Type: application/octet-stream
Size: 8480 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100605/ee8e0712/attachment.obj>


More information about the wine-devel mailing list