shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 4]

[Paul Vriens]

On 03/06/2010 07:00 PM, Ilya Basin wrote:
> JL>  Also, those TEST_LPFILE_PARSED_OK macros are ugly, and hard to fix if
> JL>  one place has a certain behavior, while another has different
> JL>  behavior.  Just use ok directly wherever you're using the macro.
> Not convinced. What you say is good for reading, but not editing.
> If someone wants to change behavior , the other person
> defined in a macro, but only in one place, he can jast as simple
> copy-paste the definition and edit it.
> In any case, it's a free country (c).

I must agree with Juan here.

Apart from that, the macro TEST_LPFILE_PARSED_ok_condition is strange in 
itself as it checks for 'expected' and this is something you always set 
yourself.

I agree with you that it's a free country and stuff like this will 
always be up for debate but in the end it's AJ that commits the patches 
and he has expressed several times not being to fond about too much macros.

-- 
Cheers,

Paul.