1/2 wined3d: Implement IWineD3DDeviceImpl_ColorFill using ClearSurface instead of 'BltOverride'

[Stefan Dösinger]

Am 11.03.2010 um 22:34 schrieb Roderick Colenbrander:

> Hi,
> 
> This patch makes IWineD3DDeviceImpl_ColorFill use Clear instead of
> BltOverride for color filling (it falls back to software blit if this
> is not possible). This change makes it possible in a next patch to
> have the GL Blt call IWineD3DDevice_ColorFill instead of the way
> around.
> 
> Regards,
> Roderick Colenbrander
> <0006-Implement-IWineD3DDeviceImpl_ColorFill-using-ClearSu.patch>
I am still wary of the changes to Blit because I have not seen(or have not understood) the overall design goal of how blits should work, and especially how ddraw blits and d3d8/9 style blits work together. This is especially visible in your patch because you still call IWineD3DBaseSurfaceImpl_Blt from ColorFill, you just moved the software vs gl codepath decision to a different place. It may be a step in the right direction, but I'd still prefer to see the overall strategy first.