[PATCH] configure.ac: use proper quoting throughout the file

Yann Droneaud yann at droneaud.fr
Mon Mar 15 05:20:39 CDT 2010


Hi,

Le lundi 15 mars 2010 à 11:13 +0100, Yann Droneaud a écrit :
> Added quoting around macro parameters as recommanded by autoconf:
> http://www.gnu.org/software/autoconf/manual/html_node/Autoconf-Language.html#Autoconf-Language
> 
> Autoconf output was checked to be the same with and without the patch,
> so that it's easy to validate the patch: configure script is exactly the
> same with or without the patch.
> 
> Note: Quoting were not added for WINE macros related to Makefile generation
> as they broke things: there are some quoting magic in aclocal.m4 not
> fixed by this patch.

As stated in the patch log, it can be applied safely.

But once applied on current HEAD, most pending patches on configure.ac
won't apply.

So if this patch is going to be applied, developer must be warned first
and hold their own patches.

I'm ok to hold this one a week or two, so pending patches could be
applied without modification before this one get applied.

I have another patches waiting to fix some autoconf constructs.

Regards.

-- 
Yann Droneaud







More information about the wine-devel mailing list