Warnings on ignored returned values

[Octavian Voicu]

Hello,

I'm trying to compile wine with --enable-maintainer-mode and I get
lots of errors like `ignoring return value of ‘xxx’, declared with
attribute warn_unused_result'. I would like to submit a few patches to
fix them.

I noticed there's a page on the wiki for this:
http://wiki.winehq.org/IgnoredReturnValues

On the other hand, there are no indications on the policy of handling
them. Sometimes we just don't care about the return value, but I
haven't found a way to tell this to the compiler other than actually
using the return value. In other cases, errors might be relevant.

For example, for the code:

if (newdir) chdir(newdir);

would the following be an acceptable fix?

if (newdir) if (chdir(newdir) == -1) /* ignore error */ ;

Should I use WARNs to print the error, in cases where it might be relevant?

Thanks,
Octavian